Re: [PATCH bpf] selftests/bpf: fix pkg-config call building sign-file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-04-26 at 22:50 +0100, Jeremy Sowden wrote:
> When building sign-file, the call to get the CFLAGS for libcrypto is
> missing white-space between `pkg-config` and `--cflags`:
> 
>   $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)
> 
> Removing the redirection of stderr, we see:
> 
>   $ make -C tools/testing/selftests/bpf sign-file
>   make: Entering directory '[...]/tools/testing/selftests/bpf'
>   make: pkg-config--cflags: No such file or directory
>     SIGN-FILE sign-file
>   make: Leaving directory '[...]/tools/testing/selftests/bpf'
> 
> Add the missing space.
> 
> Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
> Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>

Thanks.

Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>

Roberto

> ---
>  tools/testing/selftests/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index b677dcd0b77a..ad01c9e1ff12 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r
>  
>  $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
>  	$(call msg,SIGN-FILE,,$@)
> -	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \
> +	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \
>  		  $< -o $@ \
>  		  $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
>  




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux