> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Thursday, March 2, 2023 3:30 AM
>
>
> diff --git a/tools/testing/selftests/iommu/iommufd.c
> b/tools/testing/selftests/iommu/iommufd.c
> index fa08209268c42f..000fadf8110833 100644
> --- a/tools/testing/selftests/iommu/iommufd.c
> +++ b/tools/testing/selftests/iommu/iommufd.c
> @@ -186,7 +186,7 @@ FIXTURE(iommufd_ioas)
> {
> int fd;
> uint32_t ioas_id;
> - uint32_t domain_id;
> + uint32_t stdev_id;
Probably add a comment that a valid stdev_id implies a domain/hwpt
under the ioas. with that...
> TEST_F(iommufd_ioas, ioas_destroy)
> {
> - if (self->domain_id) {
> + if (self->stdev_id) {
> /* IOAS cannot be freed while a domain is on it */
> EXPECT_ERRNO(EBUSY,
> _test_ioctl_destroy(self->fd, self->ioas_id));
it's easier to understand this comment.
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
