On Wed, Feb 15, 2023, Maciej S. Szmigiero wrote: > On 15.02.2023 01:50, Ackerley Tng wrote: > > To fix this, I propose that in vm_arch_vcpu_add(), we align the > > allocated stack address and then subtract 8 from that: > > Note that if this code is ever used to launch a vCPU with 32-bit entry > point it will need to subtract 4 bytes instead of 8 bytes. > > I think it would be worthwhile to at least place a comment mentioning > this near the stack aligning expression so nobody misses this fact. Heh, I've no objection to a comment, though this really is the tip of the iceberg if we want to add 32-bit guest support in selftests.
