On Mon, Oct 24, 2022 at 09:57:53AM -0300, Wander Lairson Costa wrote: > On Sun, Oct 23, 2022 at 1:13 PM Sathyanarayanan Kuppuswamy > <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote: > > > > > > > > On 10/20/22 9:39 PM, Greg Kroah-Hartman wrote: > > >>> You are allowing userspace to spam the kernel logs, please do not do > > >>> that. > > >> Added it to help userspace understand the reason for the failure (only for > > >> the cases like request param issues and TDCALL failure). Boris recommended > > >> adding it in the previous review. > > > Again, you just created a vector for userspace to spam the kernel log. > > > No kernel driver should ever do that. > > > > > > > Brois, any comments? Do you also agree? > > > > Maybe dev_err_once() does the job? That does not make any sense when the userspace input can be different each time. This is just yet-another-ioctl, there's nothing special about it. Return an error for invalid input and don't log anything. Worst case, make it a dev_dbg() call if you really really really want to see it. thanks, greg k-h
