On Sun, Oct 23, 2022 at 1:13 PM Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote: > > > > On 10/20/22 9:39 PM, Greg Kroah-Hartman wrote: > >>> You are allowing userspace to spam the kernel logs, please do not do > >>> that. > >> Added it to help userspace understand the reason for the failure (only for > >> the cases like request param issues and TDCALL failure). Boris recommended > >> adding it in the previous review. > > Again, you just created a vector for userspace to spam the kernel log. > > No kernel driver should ever do that. > > > > Brois, any comments? Do you also agree? > Maybe dev_err_once() does the job?