On Fri, Aug 19, 2022 at 4:07 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 19 Aug 2022 12:05:58 -0700 Axel Rasmussen wrote:
> > Some recent commits added new test binaries, but forgot to add those to
> > .gitignore. Now, after one does "make -C tools/testing/selftests", one
> > ends up with some untracked files in the kernel tree.
> >
> > Add the test binaries to .gitignore, to avoid this minor annoyance.
> >
> > Fixes: d8b6171bd58a ("selftests/io_uring: test zerocopy send")
> > Fixes: 6342140db660 ("selftests/timens: add a test for vfork+exit")
> > Signed-off-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx>
> > ---
> > tools/testing/selftests/net/.gitignore | 3 ++-
> > tools/testing/selftests/timens/.gitignore | 1 +
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
> > index 0e5751af6247..02abf8fdfd3a 100644
> > --- a/tools/testing/selftests/net/.gitignore
> > +++ b/tools/testing/selftests/net/.gitignore
> > @@ -39,4 +39,5 @@ toeplitz
> > tun
> > cmsg_sender
> > unix_connect
> > -tap
> > \ No newline at end of file
> > +tap
> > +io_uring_zerocopy_tx
>
> Could you make the io_uring test the first in the file?
> That'd gets us closest to the alphabetical ordering (I know the file is
> not ordered now, but we should start moving that way).
It isn't that it's mostly ordered with a few exceptions, to me it
looks entirely random. I don't mind moving the one I'm adding but, I'm
not sure it gives much value given that.
Would folks object to just adding a second commit to this which sorts
the file? Since this file isn't changed frequently, I would say the
risk of annoying conflicts is pretty low.
