Re: [PATCH 3/5] selftests: firmware: Fix the request_firmware_into_buf() test for XZ format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/21/22 9:29 AM, Takashi Iwai wrote:
The test uses a different firmware name, and we forgot to adapt for
the XZ compressed file tests.

Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests")
https://lore.kernel.org/all/20210127154939.13288-1-tiwai@xxxxxxx/
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
---
  tools/testing/selftests/firmware/fw_filesystem.sh | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
index 731f011def78..3ac09b401a83 100755
--- a/tools/testing/selftests/firmware/fw_filesystem.sh
+++ b/tools/testing/selftests/firmware/fw_filesystem.sh
@@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0
# test with both files present
  $RUN_XZ -k $FW
+$RUN_XZ -k $FW_INTO_BUF
  config_set_name $NAME
  echo
  echo "Testing with both plain and xz files present..."
@@ -529,6 +530,7 @@ done
# test with only xz file present
  mv "$FW" "${FW}-orig"
+mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig"
  echo
  echo "Testing with only xz file present..."
  for i in $(seq 1 5); do


Thank you. Looks good to me.

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux