Hi Mika Thanks for your review On Tue, 8 Feb 2022 at 13:47, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > Hi, > > On Tue, Feb 08, 2022 at 12:45:38PM +0100, Ricardo Ribalda wrote: > > Replace the NULL checks with the more specific and idiomatic NULL macros. > > > > Reviewed-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > > --- > > drivers/thunderbolt/test.c | 130 ++++++++++++++++++------------------- > > 1 file changed, 65 insertions(+), 65 deletions(-) > > > > diff --git a/drivers/thunderbolt/test.c b/drivers/thunderbolt/test.c > > index 1f69bab236ee..f5bf8d659db4 100644 > > --- a/drivers/thunderbolt/test.c > > +++ b/drivers/thunderbolt/test.c > > You could add these too while there: > > > p = tb_property_find(dir, "foo", TB_PROPERTY_TYPE_TEXT); > > KUNIT_ASSERT_TRUE(test, !p); > > > p = tb_property_find(dir, "missing", TB_PROPERTY_TYPE_DIRECTORY); > > KUNIT_ASSERT_TRUE(test, !p); To avid keeping spamming the list. I have pushed my series to https://git.kernel.org/pub/scm/linux/kernel/git/ribalda/linux.git/log/?h=kunit_null-v5 if there are no more comments by tomorrow I will resend it to the list. Maintainers can also pick the patches from there if they prefer so. Thanks! -- Ricardo Ribalda
