Re: [PATCH v4 3/6] thunderbolt: test: use NULL macros

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

Hi,

On Tue, Feb 08, 2022 at 12:45:38PM +0100, Ricardo Ribalda wrote:
> Replace the NULL checks with the more specific and idiomatic NULL macros.
> 
> Reviewed-by: Daniel Latypov <dlatypov@xxxxxxxxxx>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
>  drivers/thunderbolt/test.c | 130 ++++++++++++++++++-------------------
>  1 file changed, 65 insertions(+), 65 deletions(-)
> 
> diff --git a/drivers/thunderbolt/test.c b/drivers/thunderbolt/test.c
> index 1f69bab236ee..f5bf8d659db4 100644
> --- a/drivers/thunderbolt/test.c
> +++ b/drivers/thunderbolt/test.c

You could add these too while there:

>  	p = tb_property_find(dir, "foo", TB_PROPERTY_TYPE_TEXT);
>  	KUNIT_ASSERT_TRUE(test, !p);

>  	p = tb_property_find(dir, "missing", TB_PROPERTY_TYPE_DIRECTORY);
>  	KUNIT_ASSERT_TRUE(test, !p);