Hi, Friendly ping for a review. > > Hello, > > The aim of this series is to make resctrl_tests run by using kselftest framework. > - I modify Makefile of resctrl_test and Makefile of selftest, to > build/run resctrl_tests by using kselftest framework. > - I set the limited time for resctrl_tests to 120 seconds, to ensure the > resctrl_tests finish in limited time. > - When resctrl file system is not supported or resctrl_tests is not run > as root, return skip code of kselftest. > - If it is not finish in limited time, terminate resctrl_tests same as > executing ctrl+c. > > Difference from v1: > - I change the order of patches according to Reinette's review. > - "LDLIBS + = -lnuma" has no dependencies on this patch series, delete > it from [PATCH v2 2/5]. > - I separate the license info of Makefile into a new patch [PATCH v2 > 3/5]. > - I separate "limited time" into a new patch [PATCH v2 4/5]. > (There is no change in [PATCH v2 1/5] and [PATCH v2 5/5]) In addition, I think > 120s is not a problem since some tests have longer timeout (e.g. net test is > 300s), please let me know if this is wrong > > Thanks, > > Shaopeng Tan (5): > selftests/resctrl: Kill the child process created by fork() when the > SIGTERM signal comes > selftests/resctrl: Make resctrl_tests run using kselftest framework > selftests/resctrl: Add license to resctrl_test Makefile > selftests/resctrl: Change default limited time to 120 seconds for > resctrl_tests > selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not > supported or resctrl is not run as root > > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/resctrl/Makefile | 20 +++++++------------ > .../testing/selftests/resctrl/resctrl_tests.c | 4 ++-- > tools/testing/selftests/resctrl/resctrl_val.c | 1 + > tools/testing/selftests/resctrl/settings | 1 + > 5 files changed, 12 insertions(+), 15 deletions(-) create mode 100644 > tools/testing/selftests/resctrl/settings > > -- > 2.27.0
