Hi, Marco, On Mon, Sep 27, 2021 at 5:17 AM Marco Elver <elver@xxxxxxxxxx> wrote: > > On Mon, 27 Sept 2021 at 00:33, 'Isabella Basso' via KUnit Development > <kunit-dev@xxxxxxxxxxxxxxxx> wrote: > > > > Split up test_hash_init so that it calls each test more explicitly > > insofar it is possible without rewriting the entire file. This aims at > > improving readability. > > > > Split tests performed on string_or as they don't interfere with those > > performed in hash_or. Also separate pr_info calls about skipped tests as > > they're not part of the tests themselves, but only warn about > > (un)defined arch-specific hash functions. > > > > Changes since v1: > > - As suggested by David Gow: > > 1. Rename arch-specific test functions. > > 2. Remove spare whitespace changes. > > - As suggested by Marco Elver: > > 1. Add struct for carrying test variables. > > Did the patches get mixed up? The struct doesn't appear to be introduced here. Yeah, thanks for the heads up! I must have mixed the messages when rebasing. Sorry about that. The struct was actually introduced in patch 2/5. Do you want to have a look at it or should I send the v3 with the correct message before that? Cheers, Isabella Basso
