On Fri, Aug 20, 2021 at 05:05:05PM +0530, Amit Kachhap wrote:
> On 8/20/21 4:25 PM, Mark Brown wrote:
> > On Fri, Aug 20, 2021 at 12:39:39PM +0530, Amit Kachhap wrote:
> > > - ASSERT_NE(0, hwcaps & HWCAP_PACA) TH_LOG("PAUTH not enabled"); \
> > > + ASSERT_NE(0, hwcaps & HWCAP_PACA) SKIP(return, "PAUTH not enabled");
> > That's what the patch does?
> Agree, I saw few other testcases where ASSERT is used along with SKIP.
> (tools/testing/selftests/core/close_range_test.c) so this way
> ASSERT_GENERIC_* macro will be clear. There will be just an extra
> log like "hwcaps & HWCAP_PACA = 0" in this case.
I'm not 100% sure I follow what you're saying here? I don't see a log
message saying "hwcaps & HWCAP_PACA = 0" on non-PAC systems, or is that
what you're saying you want to see?
> Probably your way is consistent as other tests in arm64 also just
> skips due to HWCAP mismatch.
Right, we can't usefully run tests for features not present in the
system - this sort of thing is the intent of the kselftest skip feature.
Attachment:
signature.asc
Description: PGP signature
