Re: [PATCH v8 1/5] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/11/21 11:35 AM, Shuah Khan wrote:
On 6/10/21 9:45 AM, Dave Hansen wrote:
On 6/10/21 1:30 AM, Jarkko Sakkinen wrote:
Rename symbols for better clarity:

* 'eenter' might be confused for directly calling ENCLU[EENTER].  It does    not.  It calls into the VDSO, which actually has the EENTER instruction. * 'sgx_call_vdso' is *only* used for entering the enclave.  It's not some
   generic SGX call into the VDSO.

Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

These all look fine to me.  Feel free to add my ack on them.

Since these are pure x86 selftests and the initial code went through the
x86 maintainers, should these got through them as well?  Or, since this
is only selftest code, should Shuah pick them up?


I will queue these up for 5.14-rc1


I almost applied these. Does this require root access, if so,
please add logic to skip the test if non-root user runs it.

Please check for code paths that require root access and skip
the tests.

thanks,
-- Shuah



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux