On Wed, Dec 2, 2020 at 7:05 PM David Gow <davidgow@xxxxxxxxxx> wrote: > > On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > > > * Stop leaking file objects. > > * Use self.addCleanup() to ensure we call cleanup functions even if > > setUp() fails. > > * use mock.patch.stopall instead of more error-prone manual approach > > > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > > --- > > This patch hasn't changed since v1, right? > > It's still: > Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Oops, yes. It's entirely unchanged. The only change to the entire series was a rebase + drop the second patch in favor of revamping the test_data_path() one. > > Cheers, > -- David
