On Thu, Dec 12, 2019 at 3:06 AM Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote: > > On Wed, Dec 11, 2019 at 9:45 AM Brendan Higgins > <brendanhiggins@xxxxxxxxxx> wrote: > > > > On Wed, Dec 11, 2019 at 9:40 AM SeongJae Park <sj38.park@xxxxxxxxx> wrote: > > > > > > On Wed, Dec 11, 2019 at 6:22 PM shuah <shuah@xxxxxxxxxx> wrote: > > > > > > > > On 12/11/19 9:33 AM, SeongJae Park wrote: > > > > > May I ask some comments? > > SeongJae, > > I reviewed and tested all your patches. Everything looks good to me > with one minor caveat: I tried applying your patches on > kselftest/fixes[1] and got the following error: > > error: patch failed: Documentation/dev-tools/kunit/start.rst:21 > error: Documentation/dev-tools/kunit/start.rst: patch does not apply > Patch failed at 0005 kunit: Rename 'kunitconfig' to '.kunitconfig' > > I think the merge conflict is fairly straightforward, but it would > still probably make Shuah's life easier if you rebased your patches. Appreciate your nice response, I will rebase it and send the next version! Thanks, SeongJae Park > > Cheers! > > P.S. Thanks for the patch adding the test case for test the build_dir > thing. I really appreciate that! > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes
