May I ask some comments? Thanks, SeongJae Park On Thu, 5 Dec 2019 10:34:34 +0100 SeongJae Park <sjpark@xxxxxxxxxx> wrote: > > This patchset contains trivial fixes for the kunit documentations and > the wrapper python scripts. > > This patchset is based on 'kselftest/test' branch of linux-kselftest[1] > and depends on Heidi's patch[2]. A complete tree is available at my repo: > https://github.com/sjp38/linux/tree/kunit_fix/20191205_v5 > > Changes from v4 > (https://lore.kernel.org/linux-doc/1575490683-13015-1-git-send-email-sj38.park@xxxxxxxxx/): > - Rebased on Heidi Fahim's patch[2] > - Fix failing kunit_tool_test test > - Add 'build_dir' option test in 'kunit_tool_test.py' > > Changes from v3 > (https://lore.kernel.org/linux-kselftest/20191204192141.GA247851@xxxxxxxxxx): > - Fix the 4th patch, "kunit: Place 'test.log' under the 'build_dir'" to > set default value of 'build_dir' as '' instead of NULL so that kunit > can run even though '--build_dir' option is not given. > > Changes from v2 > (https://lore.kernel.org/linux-kselftest/1575361141-6806-1-git-send-email-sj38.park@xxxxxxxxx): > - Make 'build_dir' if not exists (missed from v3 by mistake) > > Changes from v1 > (https://lore.kernel.org/linux-doc/1575242724-4937-1-git-send-email-sj38.park@xxxxxxxxx): > - Remove "docs/kunit/start: Skip wrapper run command" (A similar > approach is ongoing) > - Make 'build_dir' if not exists > > SeongJae Park (6): > docs/kunit/start: Use in-tree 'kunit_defconfig' > kunit: Remove duplicated defconfig creation > kunit: Create default config in '--build_dir' > kunit: Place 'test.log' under the 'build_dir' > kunit: Rename 'kunitconfig' to '.kunitconfig' > kunit/kunit_tool_test: Test '--build_dir' option run > > Documentation/dev-tools/kunit/start.rst | 13 +++++-------- > tools/testing/kunit/kunit.py | 18 +++++++++++------- > tools/testing/kunit/kunit_kernel.py | 10 +++++----- > tools/testing/kunit/kunit_tool_test.py | 10 +++++++++- > 4 files changed, 30 insertions(+), 21 deletions(-) > > -- > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git > [2] "kunit: testing kunit: Bug fix in test_run_timeout function", > https://lore.kernel.org/linux-kselftest/CAFd5g47a7a8q7by+1ALBtepeegLvfkgwvC3nFd8n8V=hqkV+cg@xxxxxxxxxxxxxx/T/#t) > > 2.17.1 >
