On 13/08/2019 17:28, Dave Martin wrote: > On Wed, Aug 07, 2019 at 05:04:13PM +0100, Cristian Marussi wrote: >> On 02/08/2019 18:03, Cristian Marussi wrote: >>> Added a simple fake_sigreturn testcase which places a valid >>> sigframe on a non-16 bytes aligned SP. >>> fake_sigretrun() helper function has been patched accordingly >>> to support placing a sigframe on a non-16 bytes aligned address. >>> Expects a SIGSEGV on test PASS. >>> >>> Adds also a test TODO lists holding some further test ideas. >>> >>> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx> >>> --- >>> Re-added this text after fixing the forced misaglinment procedure in >>> fake_sigreturn() itself: require a ZERO alignment and you'll get >>> your sigframe placed on a misaligned SP (2-bytes off the 16-align) >>> --- >>> .../testing/selftests/arm64/signal/signals.S | 21 +++++++++---- >>> .../arm64/signal/testcases/TODO.readme | 8 +++++ >>> .../testcases/fake_sigreturn_misaligned_sp.c | 30 +++++++++++++++++++ >>> 3 files changed, 53 insertions(+), 6 deletions(-) >>> create mode 100644 tools/testing/selftests/arm64/signal/testcases/TODO.readme >>> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c >>> >> >> When this test was re-added in V3, the related .gitignore was missed. >> It will go in V4 > > Ack, or otherwise try switching to using wildcards in .gitignore as > suggested in my reply to patch 4. Used wildcard in .gitignore as advised. > > [...] > > Cheers > ---Dave > Cheers Cristian