On Tue, May 07, 2019 at 12:38:24PM -0400, Joel Fernandes wrote: > On Sun, May 05, 2019 at 04:31:45PM -0400, Steven Rostedt wrote: > > On Sun, 5 May 2019 13:26:23 +0000 > > Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote: > > > > > On Sun, May 05, 2019 at 11:10:30AM +0200, Greg KH wrote: > > > > On Sat, May 04, 2019 at 08:36:50AM -0400, Joel Fernandes wrote: > > > > > > But, you should change S_IRUGO to the correct octal number, checkpatch > > > > > > should have barfed on this change. > > > > > > > > > > fixed, below is the updated patch inline, thanks! > > > > > > > > Please resend as a "real" submission, doing so in this format is a bit > > > > more difficult to apply. > > > > > > git am --scissors can do it, but no problem I will send as a formal > > > submission. Thanks a lot. > > > > > > > True, but a lot of us depend on scripts to pull in patches from our > > INBOX. Which is why we like them to stay with the standard format. > > Thanks makes sense. So Greg, I submitted this properly, does it look good to > you now? Steven, I would appreciate any Acks/Reviews on the patch as well: > https://lore.kernel.org/patchwork/patch/1070199/ Looks good to me, should get to it in a few days...
