On Sat, May 04, 2019 at 08:36:50AM -0400, Joel Fernandes wrote: > > But, you should change S_IRUGO to the correct octal number, checkpatch > > should have barfed on this change. > > fixed, below is the updated patch inline, thanks! Please resend as a "real" submission, doing so in this format is a bit more difficult to apply. thanks, greg k-h