On 06/15/2017 08:16 AM, Paul Elder wrote: > On 06/14/2017 04:06 AM, Shuah Khan wrote: >> On 06/12/2017 12:56 AM, Greg Kroah-Hartman wrote: >>> Second try at adding TAP 13 output format to the kselftest core. >>> >>> These patches add an initial framework to the kselftest header file to >>> provide a way for tests to output in TAP13 format, and then goes on to >>> convert 3 different tests to use the format, showing that it does work >>> well. >>> >>> The TAP13 format specification can be found here: >>> >>> Version 2: >>> - refactor the function names to drop the _tap suffix - Alice >>> >>> Paul Elder (4): >>> kselftest: add TAP13 conformant versions of ksft_* functions >>> kselftest: membarrier: convert to TAP13 output >>> kselftest: breakpoints: convert breakpoint_test to TAP13 output >>> kselftest: breakpoints: convert step_after_suspend_test to TAP13 >>> output >>> >>> .../selftests/breakpoints/breakpoint_test.c | 29 ++++++------ >>> .../breakpoints/step_after_suspend_test.c | 43 +++++++----------- >>> tools/testing/selftests/kselftest.h | 52 ++++++++++++++++++++-- >>> .../testing/selftests/membarrier/membarrier_test.c | 35 ++++++++------- >>> 4 files changed, 99 insertions(+), 60 deletions(-) >>> >> >> >> Thanks for the series. The output looks good and API is good. >> I applied the series to linux-kselftest next for 4.13-rc1 > I guess I misunderstood this. I didn't realized you accepted the > series into your tree. Thank you! > >> >> I have a few minor comments on >> >> [PATCH v2 2/4] kselftest: membarrier: convert to TAP13 output > It seems like we're still waiting on this. Should I send the > patch to make ksft_exit_skip() print output as an entirely separate > patch? > I pulled all 4 patches in. Please see linux-kselftest next latest. There might a few little issues in breakpoints patches that could be dine differently, especially including perror() strings, but I want to get this in and refine later. Please do this: - Patch 1: Send a patch to make ksft_exit_skip() print output. This will be an incremental change to your v2 - Patch 2: membarrier patch changes as recommended in my review. This will be an incremental change to your v2. Please do these patches on top of linux-kselftest next thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
