Re: [PATCH v2 0/4] kselftest: add TAP13 output format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/12/2017 12:56 AM, Greg Kroah-Hartman wrote:
> Second try at adding TAP 13 output format to the kselftest core.
> 
> These patches add an initial framework to the kselftest header file to
> provide a way for tests to output in TAP13 format, and then goes on to
> convert 3 different tests to use the format, showing that it does work
> well.
> 
> The TAP13 format specification can be found here:
> 	https://testanything.org/tap-version-13-specification.html
> 
> Version 2:
>   - refactor the function names to drop the _tap suffix - Alice
> 
> Paul Elder (4):
>   kselftest: add TAP13 conformant versions of ksft_* functions
>   kselftest: membarrier: convert to TAP13 output
>   kselftest: breakpoints: convert breakpoint_test to TAP13 output
>   kselftest: breakpoints: convert step_after_suspend_test to TAP13
>     output
> 
>  .../selftests/breakpoints/breakpoint_test.c        | 29 ++++++------
>  .../breakpoints/step_after_suspend_test.c          | 43 +++++++-----------
>  tools/testing/selftests/kselftest.h                | 52 ++++++++++++++++++++--
>  .../testing/selftests/membarrier/membarrier_test.c | 35 ++++++++-------
>  4 files changed, 99 insertions(+), 60 deletions(-)
> 


Thanks for the series. The output looks good and API is good.
I applied the series to linux-kselftest next for 4.13-rc1

I have a few minor comments on

[PATCH v2 2/4] kselftest: membarrier: convert to TAP13 output

Separate email is on its way.

Just as heads up I am going to work on converting timers, kcmp,
and futex to new tap API as these are the users of existing
kselftest API.

Thanks again for doing this work.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux