On 08/04/2016 05:20 AM, Aleksander Alekseev wrote: > Suggested patch solves two issues: > > 1) Currently documentation is unclear whether `make kselftest` should > be run before or after kernel was installed and booted. `make help` > gives a clear answer on that: "kselftest - Build and run kernel selftest > (run as root). Build, install, and boot kernel before running kselftest > on it." > > 2) Documentation states that `make kselftest` executes "unit" tests. > Technically it's not a _unit_ test if it requires to install an > application first. It's either integration or system test. To not to > confuse a user I suggest not to use a word "unit". > > Signed-off-by: Aleksander Alekseev <afiskon@xxxxxxxxx> > --- > v2: > - same as v1 but in right format > --- > Documentation/kselftest.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > diff --git a/Documentation/kselftest.txt b/Documentation/kselftest.txt > index 979eaca..dc1c692 100644 > --- a/Documentation/kselftest.txt > +++ b/Documentation/kselftest.txt > @@ -1,8 +1,9 @@ > Linux Kernel Selftests > > The kernel contains a set of "self tests" under the tools/testing/selftests/ > -directory. These are intended to be small unit tests to exercise individual > -code paths in the kernel. > +directory. These are intended to be small tests to exercise individual code > +paths in the kernel. User supposed to run these tests after building, > +installing and booting a kernel. Thanks for the patch. Please take a look at Michael's comment about how these tests are intended to be used. Please incorporate the comments and make it clear that these aren't intended to be run bu "users" > > On some systems, hot-plug tests could hang forever waiting for cpu and > memory to be ready to be offlined. A special hot-plug target is created > --- > 2.7.4 > thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
