Re: [PATCH] locking/lockdep: Simplify character output in seq_line()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 15, 2024 at 10:51:44AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 15 Jul 2024 10:42:17 +0200
> 
> Single characters should be put into a sequence.
> Thus use the corresponding function “seq_putc” for one selected call.
> 
> This issue was transformed by using the Coccinelle software.
> 
> Suggested-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Queued this at:

	https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/ lockdep-for-tip

Thanks! And given Christophe's comment, the original one is not needed,
so drop it.

Regards,
Boqun

> ---
>  kernel/locking/lockdep_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
> index e2bfb1db589d..6db0f43fc4df 100644
> --- a/kernel/locking/lockdep_proc.c
> +++ b/kernel/locking/lockdep_proc.c
> @@ -424,7 +424,7 @@ static void seq_line(struct seq_file *m, char c, int offset, int length)
>  	for (i = 0; i < offset; i++)
>  		seq_puts(m, " ");
>  	for (i = 0; i < length; i++)
> -		seq_printf(m, "%c", c);
> +		seq_putc(m, c);
>  	seq_puts(m, "\n");
>  }
> 
> --
> 2.45.2
> 





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux