Re: [PATCH] locking/lockdep: Use seq_putc() in five functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/14/24 06:25, Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 14 Jul 2024 12:18:16 +0200

Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
  kernel/locking/lockdep_proc.c | 24 ++++++++++++------------
  1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
index e2bfb1db589d..4612d1c4f45e 100644
--- a/kernel/locking/lockdep_proc.c
+++ b/kernel/locking/lockdep_proc.c
@@ -101,17 +101,17 @@ static int l_show(struct seq_file *m, void *v)

  	seq_printf(m, ": ");
  	print_name(m, class);
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');

  	if (IS_ENABLED(CONFIG_PROVE_LOCKING)) {
  		list_for_each_entry(entry, &class->locks_after, entry) {
  			if (entry->distance == 1) {
  				seq_printf(m, " -> [%p] ", entry->class->key);
  				print_name(m, entry->class);
-				seq_puts(m, "\n");
+				seq_putc(m, '\n');
  			}
  		}
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  	}

  	return 0;
@@ -175,9 +175,9 @@ static int lc_show(struct seq_file *m, void *v)

  		seq_printf(m, "[%p] ", class->key);
  		print_name(m, class);
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  	}
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');

  	return 0;
  }
@@ -379,7 +379,7 @@ static int lockdep_stats_show(struct seq_file *m, void *v)
  	/*
  	 * Zapped classes and lockdep data buffers reuse statistics.
  	 */
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
  	seq_printf(m, " zapped classes:                %11lu\n",
  			nr_zapped_classes);
  #ifdef CONFIG_PROVE_LOCKING
@@ -422,10 +422,10 @@ static void seq_line(struct seq_file *m, char c, int offset, int length)
  	int i;

  	for (i = 0; i < offset; i++)
-		seq_puts(m, " ");
+		seq_putc(m, ' ');
  	for (i = 0; i < length; i++)
  		seq_printf(m, "%c", c);
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
  }

  static void snprint_time(char *buf, size_t bufsiz, s64 nr)
@@ -512,7 +512,7 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data)
  		seq_lock_time(m, &stats->write_waittime);
  		seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_write]);
  		seq_lock_time(m, &stats->write_holdtime);
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  	}

  	if (stats->read_holdtime.nr) {
@@ -521,7 +521,7 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data)
  		seq_lock_time(m, &stats->read_waittime);
  		seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_read]);
  		seq_lock_time(m, &stats->read_holdtime);
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  	}

  	if (stats->read_waittime.nr + stats->write_waittime.nr == 0)
@@ -561,9 +561,9 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data)
  			   ip, (void *)class->contending_point[i]);
  	}
  	if (i) {
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  		seq_line(m, '.', 0, 40 + 1 + 12 * (14 + 1));
-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
  	}
  }

--
2.45.2

Acked-by: Waiman Long <longman@xxxxxxxxxx>





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux