Re: [PATCH] latencytop: Use seq_putc() in lstats_show()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 14, 2024 at 12:00:23PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 14 Jul 2024 11:52:13 +0200

Not sure why this got forwarded to me. ccing arjan@xxxxxxxxxxxxxxx
as he seems to be the author of the file.
> 
> A single line break should be put into a sequence.
> Thus use the corresponding function “seq_putc”.
> 
> This issue was transformed by using the Coccinelle software.

A couple of comments while I'm here:
* The "why" is not clear; please clarify why a single line break should
  be put into a sequence.
* I don't think that a one liner merits the "coccinelle" comment.
  However, if you *really* think it should be there, please add more
  information, like the conccinell script.

Best

-- 

Joel Granados




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux