On July 2, 2024 5:29:27 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:On July 2, 2024 3:57:27 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:On Tue, Jul 02, 2024 at 08:24:44PM +0800, Su Hui wrote:brcmf_fil_cmd_int_get() reads the value of 'io_type' and passes it to brcmf_fil_cmd_data_get(). Initialize 'io_type' to avoid garbage value.Since you're going to be resending anyway, please delete the space char from the start of the line. It's weird that brcmf_fil_cmd_data_get() uses the uninitialized data. It looks like it just goes to great lengths to preserve the original data in io_type... So it likely is harmless enough but still a strange and complicated way write a no-op.Not sure if it helps, but I tried to explain the reason in response to patch 0 (cover letter).Would it make more sense to have just one patch? It's the same issue anyway.
Yes, but I would solve it in brcmf_fil_* functions (fwil.[ch]). Regards, Arend
-- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
