Clang static checker (scan-build) has some warnings as follows.
included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c:16
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:123:2:
warning:Assigned value is garbage or undefined [core.uninitialized.Assign]
123 | __le32 data_le = cpu_to_le32(*data);
| ^~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c:138:3:warning
Value stored to 'err' is never read [deadcode.DeadStores]
There are some functions like brcmf_fil_{cmd,iovar,basscfg}_int_get()
which read the value of its parameter, but some callers have not
initialized these parameters which will be read. And this patchset fixes
these problems.
BTW, maybe merge this patchset into one patch is more better because
the num of changed code is small. I split it into multiple patches
because of these different 'Fixes' tags.
Su Hui (9):
wifi: cfg80211: avoid garbage value of 'io_type' in
brcmf_cfg80211_attach()
wifi: brcmfmac: avoid garbage value of 'status' in
brcmf_c_download_blob()
wifi: cfg80211: avoid garbage value of 'noise' in
brcmf_cfg80211_dump_survey()
wifi: cfg80211: avoid garbage value of 'chanspec' in
brcmf_cfg80211_get_channel()
wifi: cfg80211: avoid garbage value of 'freq' in
brcmf_cfg80211_mgmt_tx()
wifi: cfg80211: avoid garbage value of 'wsec' in
brcmf_cfg80211_reconfigure_wep()
wifi: cfg80211: avoid garbage value of 'wsec' in
brcmf_cfg80211_add_key()
wifi: cfg80211: avoid garbage value of 'val' in brcmf_set_key_mgmt()
wifi: cfg80211: avoid garbage value of 'wsec' in
brcmf_cfg80211_{get,config_default}_key()
.../broadcom/brcm80211/brcmfmac/cfg80211.c | 18 +++++++++---------
.../broadcom/brcm80211/brcmfmac/common.c | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
--
2.30.2
