Re: [PATCH] soc: add missing MODULE_DESCRIPTION() macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 12/06/24 09:58, Neil Armstrong ha scritto:
On 12/06/2024 07:50, Jeff Johnson wrote:
With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
---
This is the last of the issues that I see in the soc directory
---
  drivers/soc/amlogic/meson-clk-measure.c | 1 +

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # for amlogic/meson-clk-measure.c

  drivers/soc/imx/soc-imx8m.c             | 1 +
  drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
  drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
  drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
  5 files changed, 5 insertions(+)


MediaTek:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

...but I'm not sure how we should apply this? :-)

Either Arnd takes it directly, or you split it per-soc... and I don't have any
preference anyway.

(P.S.: Added Arnd to the loop)

Cheers,
Angelo

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 046522664dc1..dd70d4d2bed7 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
  }
  EXPORT_SYMBOL(cmdq_pkt_finalize);
+MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
  MODULE_LICENSE("GPL v2");

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240611-md-drivers-soc-1780b1939627








[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux