Re: [PATCH] soc: add missing MODULE_DESCRIPTION() macros

[Neil Armstrong <neil.armstrong@xxxxxxxxxx>]

On 12/06/2024 07:50, Jeff Johnson wrote:
> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
> This is the last of the issues that I see in the soc directory
> ---
>   drivers/soc/amlogic/meson-clk-measure.c | 1 +

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # for amlogic/meson-clk-measure.c

>   drivers/soc/imx/soc-imx8m.c             | 1 +
>   drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
>   drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
>   drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
>   5 files changed, 5 insertions(+)
>
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index 3f3039600357..a6453ffeb753 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -688,4 +688,5 @@ static struct platform_driver meson_msr_driver = {
>   	},
>   };
>   module_platform_driver(meson_msr_driver);
> +MODULE_DESCRIPTION("Amlogic Meson SoC Clock Measure driver");
>   MODULE_LICENSE("GPL v2");
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index ec87d9d878f3..fe111bae38c8 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -252,4 +252,5 @@ static int __init imx8_soc_init(void)
>   	return ret;
>   }
>   device_initcall(imx8_soc_init);
> +MODULE_DESCRIPTION("NXP i.MX8M SoC driver");
>   MODULE_LICENSE("GPL");
> diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c
> index 35825ee95dff..34a6f187c220 100644
> --- a/drivers/soc/ixp4xx/ixp4xx-npe.c
> +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c
> @@ -764,6 +764,7 @@ static struct platform_driver ixp4xx_npe_driver = {
>   module_platform_driver(ixp4xx_npe_driver);
>   
>   MODULE_AUTHOR("Krzysztof Halasa");
> +MODULE_DESCRIPTION("Intel IXP4xx Network Processor Engine driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_FIRMWARE(NPE_A_FIRMWARE);
>   MODULE_FIRMWARE(NPE_B_FIRMWARE);
> diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> index 244ad8d7e80b..cb112f3643e9 100644
> --- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> +++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> @@ -465,6 +465,7 @@ static struct platform_driver ixp4xx_qmgr_driver = {
>   };
>   module_platform_driver(ixp4xx_qmgr_driver);
>   
> +MODULE_DESCRIPTION("Intel IXP4xx Queue Manager driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_AUTHOR("Krzysztof Halasa");
>   
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 046522664dc1..dd70d4d2bed7 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>   }
>   EXPORT_SYMBOL(cmdq_pkt_finalize);
>   
> +MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
>   MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240611-md-drivers-soc-1780b1939627