On Fri, 22 Mar 2024 03:24:56 -0400 (EDT) Julia Lawall wrote: > > At present I find this construct unreadable. > > I may get used to it, hard to say. > > > > Also I don't see the benefit of the auto-freeing construct, > > I'd venture a guess that all the bugs it may prevent would > > have been caught by smatch. But I'm an old curmudgeon stuck > > in my ways. Feel free to experiment in Intel drivers, and we'll > > see how it works out 🤷️ > > In my experiments with of_node_put, there seem to be many functions where > removing the frees makes the function much more readable. But > kmalloc/kfree may be used in different contexts, where the management of > the memory is a smaller percentage of the overall code. So the tradeoffs > may be different. Good point! References are likely a very good use case for this sort of thing. The act of bumping a counter lacks the feeling of lifetime we get with an object :(
