On Mon, Mar 18, 2024 at 08:51:33AM +0530, Ratheesh Kannoth wrote: > On 2024-03-16 at 15:46:10, Christophe JAILLET (christophe.jaillet@xxxxxxxxxx) wrote: > > UTILITY_NAME_LENGTH is 16. So better use the former when defining the > > 'utility_name' array. This makes the intent clearer when it is used around > > line 260. > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > > --- > > net/caif/cfctrl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c > > index 8480684f2762..b6d9462f92b9 100644 > > --- a/net/caif/cfctrl.c > > +++ b/net/caif/cfctrl.c > > @@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer, > > u8 tmp8; > > struct cfctrl_request_info *req; > > int ret; > > - char utility_name[16]; > > + char utility_name[UTILITY_NAME_LENGTH]; > Reverse xmas tree. > It's always hard to know what to do when the original code isn't in the correct format. Someone sent a patch last week which fixed a bug and partially converted a declaration block into reverse Christmas tree... regards, dan carpenter
