On Sun, Nov 12, 2023 at 02:12:49PM -0500, Kent Overstreet wrote: > David, I don't want you giving this kind of advice here, and if finding > declarations is something you have trouble with - perhaps find something > easier to do. David is correct. Putting declarations in the middle of code is still frowned on. It's necessary for the __cleanup work and it's okay in for loop iterators but it's generally frowned on. Please don't force people to redo patches in non-standard style. regards, dan carpenter