On Sun, Nov 12, 2023 at 06:34:59PM +0000, David Laight wrote: > From: Kent Overstreet > > Sent: 11 November 2023 23:39 > > > > On Sat, Nov 11, 2023 at 09:19:40PM +0000, David Laight wrote: > > > From: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > > > Sent: 11 November 2023 21:02 > > > > > Variable level is being initialized a value that is never read, the > > > > > variable is being re-assigned another value several statements later > > > > > on. The initialization is redundant and can be removed. Cleans up > > > > > clang scan build warning: > > > > > > > > > > fs/bcachefs/btree_iter.c:1217:11: warning: Value stored to 'level' > > > > > during its initialization is never read [deadcode.DeadStores] > > > > > > > > > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > > > > > > > > since we're no longer gnu89, we can simply declare the variable when > > > > it's first used, like so: > > > > > > ugg... I think that is still frowned upon. > > > It makes it very difficult for the average human to find > > > the variable declaration. > > > > No, it's 2023, there's no good reason to be declaring variables before > > giving them values. > > The year has nothing to do with whether it is a good idea. > It is epically bad without -Wshadow. > (Have you ever played 'stop the declaration' in C++, it isn't fun.) > > Finding declarations is bad enough when they are at the top > of a big block, never mind in the middle of a load of assignments. David, I don't want you giving this kind of advice here, and if finding declarations is something you have trouble with - perhaps find something easier to do.
