On Tue, Sep 26, 2023 at 11:58:01PM -0700, Harshit Mogalapalli wrote: > Smatch complains about returning negative error codes from a type > bool function. > > kernel/cgroup/cpuset.c:705 cpu_exclusive_check() warn: > signedness bug returning '(-22)' > > The code works correctly, but it is confusing. The current behavior is > that cpu_exclusive_check() returns true if it's *NOT* exclusive. Rename > it to cpusets_are_exclusive() and reverse the returns so it returns true > if it is exclusive and false if it's not. Update both callers as well. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Closes: https://lore.kernel.org/r/202309201706.2LhKdM6o-lkp@xxxxxxxxx/ > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> Applied to cgroup/for-6.7. Thanks. -- tejun
