On Thu, 2023-06-15 at 06:09:20 UTC, Dan Carpenter wrote: > Smatch complains that these error paths are missing cleanup: > > drivers/mtd/mtdcore.c:983 mtd_otp_nvmem_add() > warn: missing unwind goto? > > This needs to call nvmem_unregister(mtd->otp_user_nvmem) before > returning. > > Fixes: 3b270fac8443 ("mtd: otp: Put factory OTP/NVRAM into the entropy pool") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel