Re: [PATCH] mtd: otp: clean up on error in mtd_otp_nvmem_add()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 15, 2023 at 8:09 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> Smatch complains that these error paths are missing cleanup:
>
>     drivers/mtd/mtdcore.c:983 mtd_otp_nvmem_add()
>     warn: missing unwind goto?
>
> This needs to call nvmem_unregister(mtd->otp_user_nvmem) before
> returning.
>
> Fixes: 3b270fac8443 ("mtd: otp: Put factory OTP/NVRAM into the entropy pool")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Ooops my bad.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux