On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:
> On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote:
> > Pointer variables of void * type do not require type cast.
> >
> > Signed-off-by: wuych <yunchuan@xxxxxxxxxxxx>
> > ---
> > drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > index 882b2be06ea0..10d9dab26c92 100644
> > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > @@ -904,8 +904,7 @@ static
> > int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret)
> > {
> > struct octeon_device *oct = droq->oct_dev;
> > - struct octeon_device_priv *oct_priv =
> > - (struct octeon_device_priv *)oct->priv;
> > + struct octeon_device_priv *oct_priv = oct->priv;
> >
>
> Networking code needs to be in Reverse Christmas Tree order. Longest
> lines first. This code wasn't really in Reverse Christmas Tree order
> to begine with but now it's more obvious.
Oh, duh. This obviously can't be reversed because it depends on the
first declaration. Sorry for the noise.
regards,
dan carpenter
