On Mon, May 15, 2023 at 10:11:39AM -0400, Alex Deucher wrote:
> On Mon, May 15, 2023 at 3:17 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> >
> > On Mon, May 15, 2023 at 09:34:28AM +0800, Su Hui wrote:
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > index f60753f97ac5..c837e0bf2cfc 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > @@ -1470,7 +1470,7 @@ int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
> > >
> > > static int amdgpu_debugfs_test_ib_show(struct seq_file *m, void *unused)
> > > {
> > > - struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
> > > + struct amdgpu_device *adev = m->private;
> > > struct drm_device *dev = adev_to_drm(adev);
> > > int r = 0, i;
> > >
> >
> > This declaration block was originally written in reverse Christmas tree
> > order:
> >
> > long long long variable name;
> > medium length name;
> > short name;
> >
> > So you probably want to change the order now that the lengths have
> > changed. Same in the other places as well.
>
> I don't think it's possible due to the variable dependencies unless
> you separate the declarations and assignments which doesn't seem like
> a net win to me.
Gar. I'm dumb. Sorry for the noise.
regards,
dan carpenter
