On Sat, 2021-11-27 at 17:26 +0000, Colin Ian King wrote:
> Make const pointer desc a static const array, removes a dereference
> and shrinks object code a few bytes.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/char/tpm/tpm_tis_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index b2659a4c4016..649b4229e76e 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -716,7 +716,7 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id)
>
> static int tpm_tis_gen_interrupt(struct tpm_chip *chip)
> {
> - const char *desc = "attempting to generate an interrupt";
> + static const char desc[] = "attempting to generate an interrupt";
> u32 cap2;
> cap_t cap;
> int ret;
I'd rather go for:
#define TPM_TIS_GEN_INTERRUPT_DESC "attempting to generate an interrupt"
/Jarkko
