On Thu, 16 Sep 2021 16:26:05 +0300, Dan Carpenter wrote: > This function is more complicated than necessary. > > If we change from scnprintf() to snprintf() that let's us remove the > if bytes_wrote < sizeof(protocol) checks. Also we can use > bytes_wrote ? "," : "" to print the comma and remove the separate > if statement and the "is_string_nonempty" variable. > > [...] Applied to 5.16/scsi-queue, thanks! [1/1] scsi: mpi3mr: clean up mpi3mr_print_ioc_info() https://git.kernel.org/mkp/scsi/c/76a4f7cc5973 -- Martin K. Petersen Oracle Linux Engineering