Dan, > This function is more complicated than necessary. > > If we change from scnprintf() to snprintf() that let's us remove the > if bytes_wrote < sizeof(protocol) checks. Also we can use bytes_wrote > ? "," : "" to print the comma and remove the separate if statement and > the "is_string_nonempty" variable. Applied to 5.16/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
