On Tue, Sep 7, 2021 at 3:33 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The concern here is that "ret" can be uninitialized if we hit the
> "goto next" condition on every iteration through the loop.
>
> Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during DMA mapping")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/vhost/vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index d0c0fedf2c09..170166806714 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -640,7 +640,7 @@ static int vhost_vdpa_va_map(struct vhost_vdpa *v,
> u64 offset, map_size, map_iova = iova;
> struct vdpa_map_file *map_file;
> struct vm_area_struct *vma;
> - int ret;
> + int ret = 0;
>
> mmap_read_lock(dev->mm);
>
> --
> 2.20.1
>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
