On Tue, Sep 7, 2021 at 3:32 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This should return -ENOMEM if alloc_workqueue() fails. Currently it
> returns success.
>
> Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index 5c25ff6483ad..fcd7de8dd1f2 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -1593,8 +1593,10 @@ static int vduse_init(void)
>
> vduse_irq_wq = alloc_workqueue("vduse-irq",
> WQ_HIGHPRI | WQ_SYSFS | WQ_UNBOUND, 0);
> - if (!vduse_irq_wq)
> + if (!vduse_irq_wq) {
> + ret = -ENOMEM;
> goto err_wq;
> + }
>
> ret = vduse_domain_init();
> if (ret)
> --
> 2.20.1
>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
