On Tue, May 18, 2021 at 07:21:26PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The variable i is being initialized with a value that is never read, > it is being updated later on. The assignment is redundant and can be > removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/char/ttyprintk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c > index 219fa1382396..230b2c9b3e3c 100644 > --- a/drivers/char/ttyprintk.c > +++ b/drivers/char/ttyprintk.c > @@ -52,7 +52,7 @@ static void tpk_flush(void) > > static int tpk_printk(const unsigned char *buf, int count) > { > - int i = tpk_curr; > + int i; > > for (i = 0; i < count; i++) { > if (tpk_curr >= TPK_STR_SIZE) { > -- > 2.31.1 > This is not ok for what is currently in linux-next :( greg k-h