Re: [PATCH] staging: vt665x: fix alignment constraints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 12, 2021 at 1:56 PM Edmundo Carmona Antoranz
<eantoranz@xxxxxxxxx> wrote:
>
> On Fri, Mar 12, 2021 at 3:19 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >
> >
> > I think the patch description is clear enough, but it would help to include
> > a reference to my earlier patch that tried to fix the problem before. I don't
>
> Great! I did mention it in the preceding line to the section I replied
> to, though. It has it in the patch:
>
> """
> This patch is related to 2faf12c57ef (staging: vt665x: fix alignment
> constraints, 2021-02-04)
>
> The root cause seems to be that _because_ struct ieee80211_cts is
> marked as __aligned(2),
> this requires any encapsulating struct to also have an alignment of 2.
> """
>
> Maybe it needs to be formatted in a different fashion? Should I use a
> longer (like 11 chars, maybe) ID?

My mistake. The normal references use 12-character IDs, but in this
case I just missed it because it was in the cleartext.

I would normally use a separate 'Fixes:' line for this.

       Arnd



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux