> I'm wondering whether we need to add __acquires() and __releases() > annotations to some of these functions so that sparse can catch > these cases. Thoughts? Hi Russell The more tools we have for catching locking problems the better. Jakubs patchwork bot should then catch them when a patch is submitted, if the developer did not run sparse themselves. Andrew