> Add the missing platform_device_unregister() before return > from amiga_init_devices() in the error handling case. Will the tag “Fixes” become helpful for the commit message? … > +++ b/arch/m68k/amiga/platform.c > @@ -188,8 +188,10 @@ static int __init amiga_init_devices(void) > return PTR_ERR(pdev); > error = platform_device_add_data(pdev, &a1200_ide_pdata, > sizeof(a1200_ide_pdata)); > - if (error) > + if (error) { > + platform_device_unregister(pdev); > return error; > + } > } … I suggest to add a jump target for the desired exception handling. if (error) + goto unregister_device; Regards, Markus