On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote: > > My preference would be for > > > > { > > int i; > > u32 off = 0; > > > > for (i = 0; i < TG3_SD_NUM_RECS; i++) { > > tg3_ape_scratchpad_read(tp, (u32 *)ocir, off, TC3_OCIR_LEN); > > > > if (ocir->signature != TG3_OCIR_SIG_MAGIC || > > !(ocir->version_flags & TG3_OCIR_FLAG_ACTIVE)) > > memset(ocir, 0, TG3_OCIR_LEN); > > > > off += TG3_OCIR_LEN; > > ocir++; > > } > > > OK, I'll send a V3 tomorrow. I already reviewed and applied v2, just waiting for builds to finish, let's leave it.