From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> Date: Wed, 29 Apr 2020 02:52:20 +0000 > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference > since devm_ioremap() does not check input parameters for null. > > This is detected by Coccinelle semantic patch. > > @@ > expression pdev, res, n, t, e, e1, e2; > @@ > > res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n); > + if (!res) > + return -EINVAL; > ... when != res == NULL > e = devm_ioremap(e1, res->start, e2); > > Fixes: 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()") > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx> Applied.