On Fri, May 1, 2020 at 3:51 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote: > > The value of rc is still zero from the last assignment when the error > path is taken. Fix it by setting it to -ENOMEM before the > hashtab_create() call. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Fixes: e67b2ec9f617 ("selinux: store role transitions in a hash table") > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx> > --- > security/selinux/ss/policydb.c | 1 + > 1 file changed, 1 insertion(+) Here I was just about to reply to your other patches that patch 2/4 looked fine to me but I was going to hold off on applying it until this patch came through :) Merged into selinux/next, thanks. -- paul moore www.paul-moore.com